search

devspace / devspace-user-requests

:rocket: Stay up to date with what's happening now on GitHub
https://devspace.io
164 stars 4 forks source link

Use regex for filters #42

Closed rafaelrinaldi closed 8 years ago

rafaelrinaldi commented 8 years ago

Istead of a whitelist and a blacklist I think that using pattern matching via regex would be way better. This software is for developers anyway :neckbeard: By doing this, the fields "Matching" and "Excluding" could be replaced by a single "Pattern" field in the "Filter events" modal.

Would also be nice to toggle patterns that you previously setup. That way one can easily compose even complex filters in the :wink: of an :eyes: The presets can live on the filters modal since there's plenty of space now :+1:

Thanks and keep the great work!

zenorocha commented 8 years ago

Awesome, I love this idea.

Although Pattern is way more powerful than Matching and Excluding, I think it's a good idea to keep them for beginners who are not familiar with regex yet.

zenorocha commented 8 years ago

Done!

screen shot 2016-02-09 at 10 26 14 am

Let me know what you think ;D

rafaelrinaldi commented 8 years ago

hell yes