search

devstrons / heloworld

A collection of hello world snippets in multiple programming languages.
https://heloworld.vercel.app
MIT License
20 stars 42 forks source link

adding php language #44

Closed irsayvid closed 3 years ago

irsayvid commented 3 years ago

Description

This PR fixes: N/A

Notes for Reviewers:

Signed commits

vsnthdev commented 3 years ago

Kindly, finish writing the full article with details like:

  1. Why use PHP?
  2. Where is PHP used?
  3. Popular frameworks in PHP?
  4. Links to well-written projects in PHP
  5. How to get started and set up a dev environment to write PHP code, etc.

We do not accept code snippets without the articles.

irsayvid commented 3 years ago

It wasn't mentioned in the contributing guidelines. No issues. Should I write in my preferred platform and link it here or can I link a blog which already has the required information?

vsnthdev commented 3 years ago

As the project is currently in active development, the contributing guidelines aren't fully written yet, my apologies for that. You should edit the markdown file you have submitted and write a genuine article of your own there. In other words, write the in the markdown file and update this PR.

irsayvid commented 3 years ago

@vsnthdev review this and let me know if any further changes are needed

Panquesito7 commented 3 years ago

The contributing guidelines were updated now. You can update your PR properly now. 🙂

irsayvid commented 3 years ago

@vsnthdev @Panquesito7 please review the readme file, proofread the article and suggest if any changes are needed.

irsayvid commented 3 years ago

I've updated. Please check it once again.

vsnthdev commented 3 years ago

Additional modifications to be done to this document:

  1. Add an SEO friendly title
  2. Indent the first code block properly so it looks good

I'll be submitting a PR with these modifications in a few days while working with the frontend and fixing rendering issues.