search

devtron-labs / devtron

Tool integration platform for Kubernetes
https://devtron.ai
Apache License 2.0
4.36k stars 477 forks source link

Bug: Issues with external builds #3744

Open pawan-mehta-dt opened 1 year ago

pawan-mehta-dt commented 1 year ago

📜 Description

Few issues are there with external builds

👟 Reproduction steps

  1. Create a pipeline with external builds
  2. Attach it to env which is created on cluster no longer accessible from devtron and set the deployment to auto
  3. Hit the curl request with some image
  4. Repeat step 3 with same image

👍 Expected behavior

  1. Curl request should be successful and there shouldn't be any error
  2. If the curl request has same image which is already present, it should throw an error

👎 Actual Behavior

  1. Curl request to image shows an error because it is attached to an env no longer working
  2. Curl request with same image is also successful and available as latest image which can cause multiple issues

☸ Kubernetes version

EKS 1.26

Cloud provider

AWS

🌍 Browser

Chrome

🧱 Your Environment

No response

✅ Proposed Solution

No response

👀 Have you spent some time to check if this issue has been raised before?

🏢 Have you read the Code of Conduct?

AB#4875

pawan-mehta-dt commented 2 months ago

Add a validation for image tag as well - it should be in correct format of image:tag and shouldn't start with $ etc. if registries do not support that