devtron-labs / devtron

Tool integration platform for Kubernetes
https://devtron.ai
Apache License 2.0
4.15k stars 468 forks source link

Bug: JSON data for the GCR service account is not being passed correctly during Docker login #4611

Closed ajaydevtron closed 1 month ago

ajaydevtron commented 7 months ago

📜 Description

The service account json file is not being passed correctly during docker login for GCR container registry .

ss

Criticality

P1 - High

Impact on Enterprise

ENT-DEY

👟 Steps to replicate the Issue

NA

👍 Expected behavior

It should pass the in correct format during docker login .

👎 Actual Behavior

Getting bad flag syntax for service account json data during docker login.

☸ Kubernetes version

1.25

Cloud provider

AWS

🌍 Browser

Chrome

🧱 Your Environment

No response

✅ Proposed Solution

No response

👀 Have you spent some time to check if this issue has been raised before?

🏢 Have you read the Code of Conduct?

AB#8299

azure-boards[bot] commented 6 months ago

❌ There was a problem linking to Azure Boards work item(s):

Please check the IDs and try again using the AB# syntax. Learn more

azure-boards[bot] commented 6 months ago

❌ There was a problem linking to Azure Boards work item(s):

Please check the IDs and try again using the AB# syntax. Learn more

vikramdevtron commented 1 month ago

@kartik-579 @ajaydevtron @gireesh-devtron please confirm is this still exists.

gireesh-naidu commented 1 month ago

fixed in https://github.com/devtron-labs/ci-runner/pull/150