devtron-labs / devtron

The only Kubernetes dashboard you need
https://devtron.ai
Apache License 2.0
4.4k stars 483 forks source link

Bug: Build Config - Docker file path gets preferred over custom docker file #6049

Open yuvii opened 1 week ago

yuvii commented 1 week ago

📜 Description

If there's a dockerfile path configured in the build stage, if you switch to "Create Dockerfile" option the deployment would still try to build from the file path provided.

👟 Reproduction steps

Create an app, in the build configuration enter a path for a Dockerfile, then switch to "Create Dockerfile". The deployment would then look for the file specified in the path, ignoring the created dockerfile.

image image

👍 Expected behavior

The deployment should use the selected dockerfile, regardless if there are other values available

👎 Actual Behavior

Devtron picks the docker image from the path if a value is provided, ignoring what is actively selected.

☸ Kubernetes version

EKS 1.30

Cloud provider

AWS

🌍 Browser

Opera

🧱 Your Environment

No response

✅ Proposed Solution

No response

👀 Have you spent some time to check if this issue has been raised before?

🏢 Have you read the Code of Conduct?

deepak-devtron commented 1 day ago

Hi Yuval, The custom Dockerfile feature is working as expected. However, to run the docker build command, the content needs to be saved in a file. Currently, the path is being picked from the 'I have Dockerfile' tab, which may not provide the best user experience. We appreciate your feedback and will consider this improvement in an upcoming release.

abhibhaw commented 1 day ago

@yuvii are you experiencing the same as @deepak-devtron or something different?