Closed notsatan closed 3 years ago
Given that the GITHUB_TOKEN
environment variable is needed by the docker image during runtime (and is not optional), I'm thinking of making it be mandatory in the dockerfile - i.e. docker builds would fail if the variable is not set with the build command.
@Abhinav-26 this should fix the issue with failing docker builds.
I've also modified the dockerfile to ensure that the docker build
command fails if AUTH_TOKEN
(which will be used to set the GITHUB_TOKEN
env variable) is not provided
If this is not needed, or should be a separate issue/PR by itself - let me know, I'll selectively roll this commit back!
Hi There, We thank you for your valuable contributions. Please follow the steps below for the Giveaways Entry -
@hacktoberfest
.
The Problem
As mentioned in #23, docker builds were failing with the error message
The cause of the issue was that the
ENV
command in dockerfile expects two values - the name of the environment variable, and its value. TheGITHUB_TOKEN
environment variable had no value set against it, causing docker builds to failhttps://github.com/devtron-labs/silver-surfer/blob/45804592c4062d603bec137802a37003e6a4341a/Dockerfile#L9
The Fix
This PR resolves #23
Added a new build argument named
AUTH_TOKEN
that would then be set as the value for theGITHUB_TOKEN
environment variable in dockerfileUpdated the docker build command in
README
!