devunt / make-gis-great-again

This web extension adds back "View Image" button to Google Image Search results.
MIT License
768 stars 55 forks source link

gis-vib.user.js:57 Uncaught TypeError: Cannot read property 'closest' of null #75

Closed carbolymer closed 6 years ago

carbolymer commented 6 years ago

The button does not appear. Exact error from Developer Tools is attached.

Fire-Dragon-DoL commented 6 years ago

I can confirm, same problem

wachunei commented 6 years ago

Same here, thumbnail selector must have changed.

ltdicai commented 6 years ago

Changing the thumbnail selector from let thumbnail = document.querySelector('img[name="' + container.dataset.itemId + '"]'); to let thumbnail = document.querySelector('img[id="' + container.dataset.itemId + '"]'); works just fine (tested on the userscript).

apcamargo commented 6 years ago

Same problem

wachunei commented 6 years ago

I made a PR #76, while is not merged you can use https://github.com/wachunei/make-gis-great-again/tree/fix/thumbnail-selector as unpacked extension in dev mode, just in case you are not willing to wait 😅