devuxd / active-doc-client

React, React-Bootstrap
MIT License
0 stars 4 forks source link

[Rule Executor] Incorrect functionality of surrounding nodes extractor #65

Open SaharMehrpour opened 5 months ago

SaharMehrpour commented 5 months ago

For the third case of the context-gathering i.e., starting node within method, the update correctly gathers the adjacent fields and methods. But the adjacent methods still contain the bodies, which could lead to more code than we need. I know Sahar you included a removeFunctionBodies method to implement this functionality, so the bug might be there. Or it could be that the example I looked at branched into the first case of static class first (which includes method bodies) because the starting node is in a method in a static class. In this scenario, I believe we would want to still fall into that third category.

Related to PR #59

SaharMehrpour commented 5 months ago

It was keeping all the code in the constructor, which can be helpful. But for some instances it leads to super long code we probably don't need i.e. for Project.java. I think maybe we just say include the first 20 or so lines from the constructor but not beyond that?