WIP improving people page design

devuxd / devx.cs.gmu.edu

The homepage for DevX lab.

https://devuxd.github.io/devx.cs.gmu.edu/

MIT License

0 stars 9 forks source link

WIP improving people page design #12

Closed Alaboudi1 closed 4 years ago

Alaboudi1 commented 4 years ago

new https://alaboudi1.github.io/devx.cs.gmu.edu/people/ current https://devuxd.github.io/devx.cs.gmu.edu/people/

Please let me know what you think!

SaharMehrpour commented 4 years ago

Thank you Abdulaziz. It is far better than the current design. Just a few points.

The readme is not detailed that much, but maybe it worths being updated. I think you updated a few roles in _members data which are reasonable, and I think readme can be updated accordingly.
What would the design look like if a member doesn't have a picture? How about having a dummy picture for members without ones? E.g., adding a elsif here.

Alaboudi1 commented 4 years ago

Thanks everyone for the feedback. I will be working on adding more people before merging this pull request.

luminaxster commented 4 years ago

Quick question, are the fonts in the website consistent? Aziz, don't push changes in the docs/ folder, they will be flushed once the PR is merged.

Alaboudi1 commented 4 years ago

I see @luminaxster. We are not supposed to push the doc folder because it get generated by the GitHub workflow. I think in this case we may need two .gitignore files. One for local dev and the other for the workflow. I will see if I can fix that also.

luminaxster commented 4 years ago

Let me know when you are done with changes, to review and merge =)

Alaboudi1 commented 4 years ago

@luminaxster Done!