devuxd / devx.cs.gmu.edu

The homepage for DevX lab.
https://devuxd.github.io/devx.cs.gmu.edu/
MIT License
0 stars 9 forks source link

New bib style #13

Closed SaharMehrpour closed 4 years ago

SaharMehrpour commented 4 years ago

current: https://devuxd.github.io/devx.cs.gmu.edu/publications/ demo: https://saharmehrpour.github.io/devx.cs.gmu.edu/publications/

I updated the publication page. To have a better styling, I created bib.html page with css file bibliography.css.

I removed the publication list for each member to simplify the process of adding papers. There is one inconsistency in my code:

SaharMehrpour commented 4 years ago

Alternatively, we can set first_name and last_name as names that appear in papers and have a normal name field that can be shown in the website and remove bib_id. For example,

first_name: John H.
last_name: Doe-Smith
name: John Doe
Alaboudi1 commented 4 years ago

I notice that members page has this pattern {{site.baseurl}}/members/{{first_name}}. can we do that using the author's first name instead of bib_id? I also prefer using the last name to avoid conflict with common first names. Also, we may simply loop over all publications, and only include papers that match member's last_name on the member page. Of course, this sounds like not very optimized, but a solution that may work just fine.

SaharMehrpour commented 4 years ago

@Alaboudi1 That is a valid point, and I thought about that too. Jekyll uses the file names to create URLs for members. So the pattern is more like {{site.baseurl}}/members/{{fileName}}. Right now, all file names are first names of members. We can change the file names to last names, which doesn't need any change in the implementation.

One point is about projects. The current implementation is incorrect. I am working on a new pull request with the following change in _layouts/project.html:

                <h3>Collaborators</h3>
                <div>
                    {% for collab in page.current_collaborators %}
                        {% for member in site.members %}
                            {% if member.key == collab %}
                            <div>
                                <div>
                                    <a href="{{ site.baseurl }}{{ member.url }}"><img
                                            src="{{ site.baseurl }}{{ member.image }}"></a>
                                </div>
                            </div>
                            {% endif %}
                        {% endfor %}
                    {% endfor %}
                </div>
SaharMehrpour commented 4 years ago

About the publications, I looked into the library that David added Jekyll Scholar which is also popular. Here is the documentation: https://github.com/inukshuk/jekyll-scholar. The issues are also helpful in understanding the library.

It looks like queries filter out bibitems based on conditions. However, the downside is the limited expressivity of queries. I am not sure how the queries are processed. I also couldn't figure out how we can iterate over bibitems manually (or even whether it is helpful or not). Please let me know if you found out.

Issue If we only search based on the last names, isn't is possible that two people have the same last name? In this PR, it searches for both first names and last names. The problem is that the query looks for "first_name" and "last_name" instead of "first_name last_name". For example, consider the following case:

The publication will appear for all 3 members which is incorrect. This situation may not happen, but maybe worth considering.

SaharMehrpour commented 4 years ago

I updated the style of some pages. Please check them out, and tell me what you think. https://saharmehrpour.github.io/devx.cs.gmu.edu/

Alaboudi1 commented 4 years ago

Thank you @SaharMehrpour for working on this! I have a question, do we need to have a project highlight page with collaborators and then members pages. I was wondering if we just merge this all together on the main page, would that be more concise? Instead of pointing to a member page of each collaborator, clicking on the collaborator will take you to the personal webpage. Something like amy ko website http://faculty.washington.edu/ajko/ . This is only a suggestion.

SaharMehrpour commented 4 years ago

I was thinking about having a different, kind of exciting, and non-static landing page. That's why I added carousels. Listing all projects on the Home page may be concise but is also ordinary. I also think having all projects in the Home page is more suitable for when the lab website is only a 'tab', as in Amy's website. Of course, it's my idea and we can certainly merge pages as you described.

What do you think @luminaxster?

luminaxster commented 4 years ago

We should really state the user needs for the website: we have friction between social, personal, and academic layouts, and it is affecting the effectiveness of our presentation. Since it is a research lab, we should not be the focus of the content, perhaps a short punchline about what we do and then immediately show news followed by the projects (we can add avatars as Amy does). We put ourselves and gallery photos at the end. I think news carousel works but not for research projects, they may be more effective in a grid.

SaharMehrpour commented 4 years ago

I revert all the changes other than the bib style from this PR to make it more focused.