devvsakib / power-the-web

Open-source project. Hacktoberfest2022, Diversion2k23 - Clone this repo and explore all the projects
https://ptwa.vercel.app
MIT License
75 stars 126 forks source link

[FEAT]: set width for blog page #292

Closed devvsakib closed 1 year ago

devvsakib commented 1 year ago

Is your feature request related to a problem? Please describe. Blog has 100vw width. Please width according to other's page. image

Describe the solution you'd like Check other page has fixed width. Just copy and paste the class names to the blog page

IMPORTANT If it's your first Contribution to this project, please add your details to the Contributors file File Path: src/json/Contributors.json and you have to MUST read the contributing guideline before you start. Here

If you do not add your details, your PR will be Close

devvsakib commented 1 year ago

check the project page width. copy the classes that are used in the project page and paste them to the blog page. Very simple image

karthiknadar1204 commented 1 year ago

i would like to work on this issue,please assign it to me.

devvsakib commented 1 year ago

Assigned @karthiknadar1204

karthiknadar1204 commented 1 year ago

starting work on this issue

karthiknadar1204 commented 1 year ago

@devvsakib ,applying the className directly from the projects page makes the contents of the blog page shrink and hard to read . will have to add some manual changes,will be done soon

devvsakib commented 1 year ago

use layout components @karthiknadar1204 and change grid style

karthiknadar1204 commented 1 year ago

Might have to reduce the individual card size by a few pixels while fixing the layout,will share an updated pic before committing the changes soon

karthiknadar1204 commented 1 year ago

@devvsakib ,will submit a pr tomorrow along with a screenshot Thank you

devvsakib commented 1 year ago

Sure🟩

karthiknadar1204 commented 1 year ago

@devvsakib ,done with the issue, reduced the size of the card individually in order to be contained inside the reduced container but unable to reduce the adjacent spacing between the cards horizontally.

Tried applying a negative margingas well but it reduces the vertical distance which is already apt.

will try fixin the issue again tomorrow by reducing the margin of the individual cards.

Thank you

devvsakib commented 1 year ago

I will work on this issue @karthiknadar1204

karthiknadar1204 commented 1 year ago

so should i initiate a pr?

devvsakib commented 1 year ago

ok