devvsakib / power-the-web

Open-source project. Hacktoberfest2022, Diversion2k23 - Clone this repo and explore all the projects
https://ptwa.vercel.app
MIT License
75 stars 126 forks source link

[FEAT]: improve mobile navbar #360

Closed devvsakib closed 11 months ago

devvsakib commented 1 year ago

Is your feature request related to a problem? Please describe. Mobile navbar doesn't look good. We can add some animation when the user toggles the menu. image

Describe the solution you'd like Add a cool animation for toggles, and Redesign the mobile nav according to you.

IMPORTANT If it's your first Contribution to this project, please add your details to the Contributors file File Path: src/json/Contributors.json and you have to MUST read the contributing guideline before you start. Read this Guideline Before you start

If you do not add your details or assigned to issue, your PR will be Close

Srujan1527 commented 1 year ago

Assign it to me @devvsakib

devvsakib commented 1 year ago

Assigned @Srujan1527

karthiknadar1204 commented 1 year ago

@devvsakib ,can i also work on this issue? I had some good ideas to implement

Srujan1527 commented 1 year ago

Sure we will work together

On Sat, Apr 8, 2023 at 3:18 PM karthik nadar @.***> wrote:

@devvsakib https://github.com/devvsakib ,can i also work on this issue? I had some good ideas to implement

— Reply to this email directly, view it on GitHub https://github.com/devvsakib/power-the-web/issues/360#issuecomment-1500848919, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWTF4YECQ3P7UHVYPQ7CTBDXAEYATANCNFSM6AAAAAAWWXT43E . You are receiving this because you were mentioned.Message ID: @.***>

devvsakib commented 1 year ago

Great Team🟢

karthiknadar1204 commented 1 year ago
Screenshot 2023-04-08 at 10 24 37 PM

I have aligned the elements of the mobile navbar to the center,is this fine or wold you like to change it? @devvsakib

karthiknadar1204 commented 1 year ago

should i initiate a pr @devvsakib ?

devvsakib commented 1 year ago

No, the centered menu doesn't look great.

karthiknadar1204 commented 1 year ago

Fine,will change it any suggestions @devvsakib @Srujan1527

karthiknadar1204 commented 1 year ago

@devvsakib ,was thinking of adding a drawer effect that pops up from left side when we click the burger-menu occupying the left-height,will try implementing and share it once again

devvsakib commented 1 year ago

great!

karthiknadar1204 commented 1 year ago

can i incorporate an extrenal css framework to simplify the work like tailwind css @devvsakib as the navbar.css does not have any tailwind specific component so would it be fine if i use it?

devvsakib commented 1 year ago

of course, we can use it.

karthiknadar1204 commented 1 year ago

Have begun the work,will merge a pr by tuesday for sure

Thank you

otnansirk commented 1 year ago

Is this case over ? I don't see any change in mobile navbar.