search

devwaker / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

ANGLE asserts in Chromium layout tests #456

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The tests are in LayoutTests/css3/filters/custom/*

e.g. 
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT
%20Blink&tests=css3%2Ffilters%2Fcustom%2Fcustom-filter-array-uniform-indirect-in
dex.html

I think it is this: https://codereview.appspot.com/11679046.

The ANGLE roll is reverted.

Here is a call stack for an assertion on a linux build bot:

crash log for renderer (pid 12581):
STDOUT: #CRASHED - renderer (pid 12581)
STDERR: content_shell --type=renderer --disable-gpu-vsync 
--enable-experimental-web-platform-features --enable-logging 
--enable-inband-text-tracks --force-device-scale-factor=1.0 --no-sandbox 
--touch-events=enabled --use-gl=osmesa --disable-threaded-animation 
--lang=en-US --dump-render-tree --channel=12545.0.349453633: 
../../third_party/angle_dx11/src/compiler/PoolAlloc.cpp:22: bool 
InitializePoolIndex(): Assertion `PoolIndex == (static_cast<OS_TLSIndex>(-1))' 
failed.
STDERR: Received signal 6
STDERR:  [0x7f20cd51d9dc] base::debug::StackTrace::StackTrace()
STDERR:  [0x7f20cd51d2e3] base::debug::(anonymous 
namespace)::StackDumpSignalHandler()
STDERR:  [0x7f20c29bdcb0] <unknown>
STDERR:  [0x7f20c2625425] gsignal
STDERR:  [0x7f20c2628b8b] abort
STDERR:  [0x7f20c261e0ee] <unknown>
STDERR:  [0x7f20c261e192] __assert_fail
STDERR:  [0x7f20be991f1e] InitializePoolIndex()
STDERR:  [0x7f20be9802ad] InitProcess()
STDERR:  [0x7f20be9405e2] ShInitialize
STDERR:  [0x7f20c818f7ea] WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge()
STDERR:  [0x7f20c828ceab] 
WebCore::CustomFilterGlobalContext::createShaderValidator()
STDERR:  [0x7f20c828ce3b] 
WebCore::CustomFilterGlobalContext::mixShaderValidator()
STDERR:  [0x7f20c8298773] 
WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram()
STDERR:  [0x7f20c828d4a2] WebCore::CustomFilterValidatedProgram::create()
STDERR:  [0x7f20c828d160] 
WebCore::CustomFilterGlobalContext::getValidatedProgram()
STDERR:  [0x7f20c8aba4cf] WebCore::RenderLayer::computeFilterOperations()
STDERR:  [0x7f20c8abaa03] 
WebCore::RenderLayer::updateOrRemoveFilterEffectRenderer()
STDERR:  [0x7f20c8ab8dd5] WebCore::RenderLayer::updateFilters()
STDERR:  [0x7f20c8ab9006] WebCore::RenderLayer::styleChanged()
STDERR:  [0x7f20c8adf39c] WebCore::RenderLayerModelObject::styleDidChange()
STDERR:  [0x7f20c8a12715] WebCore::RenderBox::styleDidChange()
STDERR:  [0x7f20c89a43dc] WebCore::RenderBlock::styleDidChange()
STDERR:  [0x7f20c8b11ca2] WebCore::RenderObject::setStyle()
STDERR:  [0x7f20c8b1135c] WebCore::RenderObject::setAnimatableStyle()
STDERR:  [0x7f20c8651906] WebCore::Element::recalcStyle()
STDERR:  [0x7f20c8651d1c] WebCore::Element::recalcStyle()
STDERR:  [0x7f20c8651d1c] WebCore::Element::recalcStyle()
STDERR:  [0x7f20c86059e2] WebCore::Document::recalcStyle()
STDERR:  [0x7f20c8605d9f] WebCore::Document::updateStyleIfNeeded()
STDERR:  [0x7f20c8608105] WebCore::Document::implicitClose()
STDERR:  [0x7f20c918773f] WebCore::FrameLoader::checkCallImplicitClose()
STDERR:  [0x7f20c91874d3] WebCore::FrameLoader::checkCompleted()
STDERR:  [0x7f20c91872ba] WebCore::FrameLoader::loadDone()
STDERR:  [0x7f20c91d078e] WebCore::ResourceFetcher::didLoadResource()
STDERR:  [0x7f20c91a5366] WebCore::ResourceLoader::releaseResources()
STDERR:  [0x7f20c91a6996] WebCore::ResourceLoader::didFinishLoading()
STDERR:  [0x7f20be044f91] 
webkit_glue::WebURLLoaderImpl::Context::OnCompletedRequest()
STDERR:  [0x7f20c5b0db14] content::ResourceDispatcher::OnRequestComplete()
STDERR:  [0x7f20c5b11642] DispatchToMethod<>()
STDERR:  [0x7f20c5b105a0] ResourceMsg_RequestComplete::Dispatch<>()
STDERR:  [0x7f20c5b0e8ec] content::ResourceDispatcher::DispatchMessage()
STDERR:  [0x7f20c5b0ccab] content::ResourceDispatcher::OnMessageReceived()
STDERR:  [0x7f20c5a9005f] content::ChildThread::OnMessageReceived()
STDERR:  [0x7f20cee89c40] IPC::ChannelProxy::Context::OnDispatchMessage()
STDERR:  [0x7f20cee8d952] base::internal::RunnableAdapter<>::Run()
STDERR:  [0x7f20cee8d422] base::internal::InvokeHelper<>::MakeItSo()
STDERR:  [0x7f20cee8ccc9] base::internal::Invoker<>::Run()
STDERR:  [0x7f20cd51218d] base::Callback<>::Run()
STDERR:  [0x7f20cd56d982] base::MessageLoop::RunTask()
STDERR:  [0x7f20cd56daa6] base::MessageLoop::DeferOrRunPendingTask()
STDERR:  [0x7f20cd56dfc9] base::MessageLoop::DoWork()
STDERR:  [0x7f20cd574a84] base::MessagePumpDefault::Run()
STDERR:  [0x7f20cd56d525] base::MessageLoop::RunInternal()
STDERR:  [0x7f20cd56d3dc] base::MessageLoop::RunHandler()
STDERR:  [0x7f20cd5a9de8] base::RunLoop::Run()
STDERR:  [0x7f20cd56cd64] base::MessageLoop::Run()
STDERR:  [0x7f20c5ec65ad] content::RendererMain()
STDERR:  [0x7f20c55cf9b9] content::RunZygote()
STDERR:  [0x7f20c55cfbda] content::RunNamedProcessTypeMain()
STDERR:  [0x7f20c55d0d4c] content::ContentMainRunnerImpl::Run()
STDERR:  [0x7f20c55cf047] content::ContentMain()
STDERR:   r8: 000000000000005c  r9: 0101010101010101 r10: 0000000000000008 r11: 
0000000000000202
STDERR:  r12: 00007f20be9b5688 r13: 00007f20be9b58b0 r14: 00007fff7dba22b0 r15: 
00007fff7dba22b8
STDERR:   di: 0000000000003125  si: 0000000000003125  bp: 00007f20be9b5650  bx: 
00007f20b33c0000
STDERR:   dx: 0000000000000006  ax: 0000000000000000  cx: ffffffffffffffff  sp: 
00007fff7dba0cf8
STDERR:   ip: 00007f20c2625425 efl: 0000000000000202 cgf: 0000000000000033 erf: 
0000000000000000
STDERR:  trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
STDERR: #EOF

Original issue reported on code.google.com by apatr...@chromium.org on 1 Aug 2013 at 8:58

GoogleCodeExporter commented 9 years ago 
Yes, this was surely caused by https://codereview.appspot.com/11679046 .

Not sure how this worked previously. It doesn't really work if two separate 
entities in the same process call ShInitialize() and ShFinalize().

Original comment by kbr@chromium.org on 1 Aug 2013 at 10:49

GoogleCodeExporter commented 9 years ago 
Earlier ANGLE ignored subsequent calls to ShInitialize. Please review patch to 
restore original behavior:

https://codereview.appspot.com/11916046/

Original comment by alokp@chromium.org on 1 Aug 2013 at 10:58

GoogleCodeExporter commented 9 years ago 
Fixed in rb93f84a.
https://code.google.com/p/angleproject/source/detail?r=b93f84a

Original comment by alokp@chromium.org on 13 Aug 2013 at 4:22