ANGLE doesn't build with bison 3

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Upgrade to bison 3.0
2. Try build ANGLE
3. ??

What is the expected output? What do you see instead?
That it builds. It doesn't.

Please provide any additional information below.
I have attached a patch made against ANGLE in WebKit that fixes compatibility 
with bison 3.0

Original issue reported on code.google.com by carew...@gmail.com on 15 Aug 2013 at 10:28

• Blocking: #854

Attachments:

• ANGLE.patch

[GoogleCodeExporter]

I've tried it with ANGLE from git master (ba2cfe7) and it also worked fine.

Original comment by raphael.kubo.da.costa@intel.com on 15 Aug 2013 at 11:13

[GoogleCodeExporter]

By the way, this works with Bison 2.3 also (issue 449 is trying to make 
glslang.y Bison 2.3 compatible) so this won't add any problems for me

Original comment by achriste...@gmail.com on 15 Aug 2013 at 4:31

[GoogleCodeExporter]

I think this patch would also be unnecessary from my end if WebKit starts 
including the Bison-generated files instead of generating our own.  It might be 
nice from your end if you ever plan to upgrade to the newest version of Bison.

Original comment by achriste...@gmail.com on 20 Nov 2013 at 9:48

[GoogleCodeExporter]

WebKit used pregenerated files for a short while until this patch landed in the 
WebKit copy of bison. We prefer to ship sources.

Original comment by carew...@gmail.com on 20 Nov 2013 at 10:06

[GoogleCodeExporter]

Original comment by jmad...@chromium.org on 19 Dec 2014 at 9:02

• Changed state: Started

[GoogleCodeExporter]

Original comment by jmad...@chromium.org on 19 Dec 2014 at 9:02

• Now blocking: #854

[GoogleCodeExporter]

@carewolf, are you still reading this issue? Why do you prefer to ship sources, 
and which organization are you referring to by "we"? I'm considering 
redesigning ANGLE to use a version of bison either provided by DEPS or by the 
OS.

Original comment by jmad...@chromium.org on 22 Dec 2014 at 7:06

[GoogleCodeExporter]

I was referring to the webkit project, and sources are preferred because the 
only reason WebKit is open source is due to LGPL requirements.

Is ANGLE really still not bison 3 compatible??

Original comment by carew...@gmail.com on 22 Dec 2014 at 7:20

[GoogleCodeExporter]

We were limited by the version of bison that shipped with cygwin on Windows, 
which until somewhat recently was < 3. Do you know where WebKit pulls its 
version of Bison from? It seems the one on OSX by default is 2.3 IIRC.

Original comment by jmad...@chromium.org on 22 Dec 2014 at 7:23

[GoogleCodeExporter]

As a linux developer I just use the bison installed on my system.

Original comment by carew...@gmail.com on 22 Dec 2014 at 7:29

[GoogleCodeExporter]

IIRC, this bug was originally reported because someone was building gtk webkit 
back when we ran bison as part of the build process, but apple got permission 
to put the bison-generated code into their repository with a clarification that 
it was using the bsd license. Now, apple webkit does not run bison as part of 
the build process. We just compile the bison-generated code that is in the 
repository. 

Original comment by achriste...@gmail.com on 22 Dec 2014 at 7:42

[GoogleCodeExporter]

Ah-- should we now be able to update our Bison dependency independent of 
WebKit? That'd simplify things considerably, aside from the complication that 
OSX's default version is still ancient.

Original comment by shannonw...@chromium.org on 22 Dec 2014 at 8:21

[GoogleCodeExporter]

I think so, as long as the generated code is still included in the repository 
and the license of the generated code doesn't change. 

Original comment by achriste...@gmail.com on 22 Dec 2014 at 8:40

[GoogleCodeExporter]

We should be migrated to bison 3 now, and the wiki is updated. We'll stick with 
shipping pre-generated sources for now, since it's the simplest solution that 
works for everyone.

Original comment by jmad...@chromium.org on 5 Jan 2015 at 10:00

• Changed state: Fixed