search

devwaker / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Image11::generateMipmaps maps source texture as D3D11_MAP_WRITE #470

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
In Image11 on the master branch, map() is still always using D3D11_MAP_WRITE as 
the map type, which causes a performance penalty when generating mipmaps, as 
that requires read access. This was fixed as part of the texture handling 
restructuring on the es3proto branch. We'll need to bring the map type part of 
that fix over to master.

Original issue reported on code.google.com by shannonw...@google.com on 27 Aug 2013 at 8:58

GoogleCodeExporter commented 9 years ago 
Can reproduce with this:
http://webgl-bench.appspot.com/

Switching to D3D11_MAP_READ for the source image in generateMipmaps makes the 
D3D11 renderer faster than the DX9 renderer. With D3D11_MAP_WRITE it works but 
it's almost half the speed.

Original comment by apatr...@chromium.org on 27 Aug 2013 at 9:16

GoogleCodeExporter commented 9 years ago 
Review URL: https://codereview.appspot.com/13253044

Original comment by geofflang@chromium.org on 27 Aug 2013 at 9:20

GoogleCodeExporter commented 9 years ago 
jmadill: review plz

Original comment by shannonw...@chromium.org on 27 Aug 2013 at 9:24

GoogleCodeExporter commented 9 years ago 
LGTM, no comments

Original comment by jmad...@chromium.org on 28 Aug 2013 at 1:51

GoogleCodeExporter commented 9 years ago 
Has this one landed?

Original comment by shannonw...@chromium.org on 9 Sep 2013 at 2:08

GoogleCodeExporter commented 9 years ago

Original comment by geofflang@chromium.org on 9 Sep 2013 at 2:19