search

devwaker / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Vertex conversion detection in DX9 is incorrect #485

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
VertexBuffer9::requiresConversion() currently returns true if it's an identity 
conversion, but it should be returning the inverse.

Original issue reported on code.google.com by shannonw...@chromium.org on 16 Oct 2013 at 3:34

GoogleCodeExporter commented 9 years ago 
Put a CL up for review at https://codereview.appspot.com/14737043/ but this is 
a non-issue, VertexBuffer::requiresConversion is only called to determine if 
direct storage is possible and it never is in D3D9.

Original comment by geofflang@chromium.org on 16 Oct 2013 at 4:25

GoogleCodeExporter commented 9 years ago 
Fix landed at 9e30c6bf5091344a3426b66cdf79b9ca679b9d1d.

Original comment by geofflang@chromium.org on 16 Oct 2013 at 5:25