devxoul / RxViewController

RxSwift wrapper for UIViewController and NSViewController
MIT License
347 stars 63 forks source link

Removed superfluous access modifiers to silence Swift 5 warnings #16

Closed tcldr closed 5 years ago

tcldr commented 5 years ago

Eliminates warnings when building with Xcode 10.2b2

devxoul commented 5 years ago

Can I access those variables without public modifier in Swift 4?

tcldr commented 5 years ago

From the docs: “you can mark an extension with an explicit access level modifier (for example, private extension) to set a new default access level for all members defined within the extension. This new default can still be overridden within the extension for individual type members.”

This is the case even for Swift 4.

The difference in Swift 5 is that you now get a warning if you set a property access modifier that is the same as the default access level already set by the enclosing scope.

Sent from my iPhone

On 9 Feb 2019, at 05:08, Jeon Suyeol notifications@github.com wrote:

Can I access those variables without public modifier in Swift 4?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

devxoul commented 5 years ago

Thanks for your contribution!

tcldr commented 5 years ago

Pleasure! Happy to help. Thanks for a great library.