devxoul / Then

✨ Super sweet syntactic sugar for Swift initializers
MIT License
4.18k stars 290 forks source link

Add TVOS & OSX target in project and cocoapod podspec #13

Closed phimage closed 8 years ago

phimage commented 8 years ago

For carthage

devxoul commented 8 years ago

@phimage, thanks for your work! Especially for podspec.

However, why do we need seperated targets?

phimage commented 8 years ago

For cocoapod no need to add targets

For xcode we need to test the compilation using the corresponding OS (even if there is no UIKit, Cocoa dependencies) One target = one OS

And carthage use the shared scheme of target to compile for each OS (in separated folder) Travis too use scheme, so you or I can edit .travis.yml to compil for each OS target/Scheme

devxoul commented 8 years ago

Scheme is already shared. For travis, I think this PR should have test code for each targets.

But actually I'm not sure separating target is necessary.

phimage commented 8 years ago

Test code for each target is not mandatory except complex codes or issue with 32/64 bits, many projects choose one OS to do unit tests

Ok you look for the more clean way to add other OS. Until know I see only project with multiples targets. If its the directories that bother you (ThenOSX, ThenTVOS) it's possible to remove them or regroup them (the requirements is that files must exist and added to targets, no matter where the files are)

devxoul commented 8 years ago

Oh, I mean the .travis.yml file. Apologize for unclear words. (For example, https://github.com/devxoul/SwiftyColor/blob/master/.travis.yml)

Exactly. I don't want to make directories for each targets. Well, how about SwiftyJSON's approach? I think it seemed to be more clean :smile:

phimage commented 8 years ago

I do it

devxoul commented 8 years ago

@phimage, thank you very much :smile::+1: