search

devxoul / UITextView-Placeholder

A missing placeholder for UITextView
MIT License
1.48k stars 259 forks source link

add placeholderFont to fixed attributedPlaceholder font overrided #21

Closed aelam closed 8 years ago

aelam commented 8 years ago

see #20

devxoul commented 8 years ago

@aelam, Thanks for your work.

However, I cannot merge your PR because:

  1. I'm trying to make UITextView+Placeholder to follow the behaviors of the placeholder of UITextField. UITextField does not have placeholderFont property.
  2. There's too many unnecessary file diffs.

Thanks.

aelam commented 8 years ago

try UITextView.

Sent from my iPhone

On Jan 22, 2016, at 4:47 PM, Suyeol Jeon notifications@github.com wrote:

@aelam, Thanks for your work.

However, I cannot merge your PR because:

I'm trying to make UITextView+Placeholder to follow the behaviors of the placeholder of UITextField. UITextField does not have placeholderFont property. There's too many unnecessary file diffs. Thanks.

— Reply to this email directly or view it on GitHub.

devxoul commented 8 years ago

It has been fixed in #27. Thank you for waiting, guys!