search

devyumao / angular2-busy

Show busy/loading indicators on any promise, or on any Observable's subscription.
http://devyumao.github.io/angular2-busy/demo/asset/
MIT License
314 stars 102 forks source link

Not working angular cli 1.0.0-beta.24 #27

Closed dsl-src closed 7 years ago

dsl-src commented 7 years ago

ERROR in BusyModule is not an NgModule

adarshakr commented 7 years ago

same here

tobibrandenberg commented 7 years ago

I can confirm that issue

thor089 commented 7 years ago

Unfortunately this issue occurs also in my project since I use angular2-busy.

There is a discussion on angular-cli https://github.com/angular/angular-cli/issues/3426

It looks like "3rd-party libs needing to publish ng module meta data" in .module.metadata.json in src.

beeman commented 7 years ago

From the issue mentioned by @thor089 , here is a guide on how to publish an Angular module that might help fixing the issue:

https://medium.com/@cyrilletuzi/how-to-build-and-publish-an-angular-module-7ad19c0b4464#.3p2xd74qr

figuerres commented 7 years ago

also the option to set the config with .forRoot also creates error messages with angular cli. calling functions not allowed is part of the message.

figuerres commented 7 years ago

i just started a fork from this and will see if i can update it to work with angular cli see here: https://github.com/figuerres/ng-busy give me a few days and then see if you want to add to this...

crowmagnumb commented 7 years ago

Did you ever get this working? I too have this problem.

figuerres commented 7 years ago

@crowmagnumb please post on my form if you are asking about it. i have code that will be checked in tomrrow on my fork https://github.com/figuerres/ng-busy

i do not yet have it "packaged" for node modules but do have a set of files that work, i just had to update the dependcancies and also get another package updated.

please read my new post on my forked site.

crowmagnumb commented 7 years ago

No thank you @figuerres. I feel you went off in a direction that is too far removed. I'll wait for a simpler fix from within.

crowmagnumb commented 7 years ago

Although it does feel like this project is abandoned. :)

figuerres commented 7 years ago

If you get the code from my fork it's the same code I just updated the dependencies on packages so it works with angular click, not sure what you mean ? Just have not had time yet to finish packaging it for npm.