search

devyumao / angular2-busy

Show busy/loading indicators on any promise, or on any Observable's subscription.
http://devyumao.github.io/angular2-busy/demo/asset/
MIT License
314 stars 102 forks source link

Don't rely on angular2-dynamic-component #39

Closed a-zen closed 7 years ago

a-zen commented 7 years ago

The module angular2-dynamic-component is no longer necessary as angular supports this feature now directly with NgComponentOutlet.

angular2-busy should use the angular feature directly instead of a additional module

al-pt-old commented 7 years ago

A good idea. Since 4.0.x The module completed its task and is not maintained anymore.

*ngComponentOutlet= ngComponentOutletNgModuleFactory <=> componentModules content <=> componentTemplate

devyumao commented 7 years ago

Thank you, @a-zen and @apoterenko . Your suggestions are great! Now the module does not rely on angular2-dynamic-component any more. Please update to the latest version.

al-pt-old commented 7 years ago

https://github.com/devyumao/angular2-busy/pull/47