Open windmaomao opened 7 years ago
If this component is created for promise or one time subscription, it's fine.
But normally whenever subscription is mentioned, people assume it's a continuous stream. And to be honest, spinner in angular should be designed using observable, because application wise spinner is not a one time thing. Ex. https://hassantariqblog.wordpress.com/2016/12/03/angular2-using-loaderspinner-as-angular-service-in-angular-2-application/
If this component is created for promise or one time subscription, it's fine.
But normally whenever subscription is mentioned, people assume it's a continuous stream. And to be honest, spinner in angular should be designed using observable, because application wise spinner is not a one time thing. Ex. https://hassantariqblog.wordpress.com/2016/12/03/angular2-using-loaderspinner-as-angular-service-in-angular-2-application/