search

devyumao / angular2-busy

Show busy/loading indicators on any promise, or on any Observable's subscription.
http://devyumao.github.io/angular2-busy/demo/asset/
MIT License
314 stars 102 forks source link

RxJS 6 / Angular 6 Compatiability #93

Open isaackwan opened 6 years ago

isaackwan commented 6 years ago

Hey there - thanks for your work on this! It really made my life much simplier.

However, I just wanted to give you a heads up on RxJS 6. They now have a slightly different import path, making this module not working on Angular 6+.

You can kind more details here:

mtpultz commented 6 years ago

You can to fork the repository and replace all occurrences of rxjs/Subscription with rxjs in the /build folder, then just pull your fork down using npm instead of the original

mattqs commented 6 years ago

I made a version that works with Angular 6: qs-angular2-busy

deyvidfk commented 5 years ago

Did not they think about the possibility of doing a pull-request with the implementation of compatibility with the "angular@^6"? It would help by giving continuity to the project and to those who already use this lib.

jtc10005 commented 3 years ago

I am going to start working on getting this upgraded to support angular 6+. Im going to have to do it for work so might as well do it here so everyone will benefit.

jtc10005 commented 3 years ago

I have got the library set up and demo site working using angular-cli. The repo is here, https://github.com/jtc10005/angular2-busy But I am having trouble getting the busy.component to load the dynamic component. I dont have much experience with that, If anyone wants to take a look and povide some pointers I would appreciate it.