search

devzwf / pihole-dot-doh

Official pihole docker both DoT (DNS over TLS) and DoH (DNS over HTTPS).
GNU General Public License v3.0
8 stars 4 forks source link

Docker Hub update + IPv6 #20

Open Altheran88 opened 5 days ago

Altheran88 commented 5 days ago

Hello dev, I am using your image which is awesome work btw :)

I would have 2 inquiries.

1st. The version that seems to be on Docker Hub doesn't seem to be the one described in the latest version of this repo (DNS1/2 vs PIHOLEDNS for example). Would it be possible to update latest or provide a new tag for this version as to not break existing deployments ?

  1. IPv6 : OMG that is no so simple to deploy, resources and documentation not being what it is for IPv4. So here are my questions.

Let say my container gets it's IPv6 address via 1 of these methods : DHCPv6, SLAAC, Static (I would prefer SLAAC), and that I use the DoH service (cloudflared) and that I would like a full dual stack setup.

So container IPs = 192.168.1.2, 2606:6d00:xxxx:xx24::2 = Pihole would answer queries send to both addresses.

Pihole itself, inside the container, queries Cloudflared on 127.1.1.1#5153, is there also an IPv6 address it will query in case of an IPv6 lookup or one I have to/can configure somewhere ?

I figured that I just have to edit the cloudflared.yml to add these to the proxy-dns-upstream property so it also forward lookups to the IPv6 endpoints :

proxy-dns-upstream:

Finally, I don't quite get how to use these variables (Old -> New)

This one I think I got right. "DNS1" and "DNS1" -> "PIHOLEDNS" = Seems to be the where pi-hole will lookup himself, in my use case, it needs to be 127.1.1.1#5153 to query cloudflared (any IPv6 value I could add, like ::1:1#5153 ?)

Should these be my container's IPs ? (192.168.1.2 and 2606:6d00:xxxx:xx24::2 respectively) "ServerIP" -> "FTLCONF_LOCAL_IPV4" "ServerIPv6" -> "FTLCONF_LOCAL_IPV6"

Thank you very much for your work, and your help !

devzwf commented 5 days ago

Hello @Altheran88 I will review all that tonight when i get back home and will update you i am on the road at the moment and i will be better position at home. Thanks

devzwf commented 5 days ago

So for your point 1 it is was just a documentation who was not updated. i update the doc on docker HUB the image on docker hub is build from the source from this repo.

For the IPV6 question i will need more time to review and test , as i did not test that enough.

Altheran88 commented 5 days ago

So for your point 1 it is was just a documentation who was not updated. i update the doc on docker HUB the image on docker hub is build from the source from this repo.

Weird, as while installing the App from the Unraid apps, the template used the "old" DNS1/DNS2 and ServerIP/v6 instead of the "New" PIHOLEDNS and FTLCONF_LOCAL_IPVx.

So right now my container is running with the old variables just fine.

Edit : Oh, I sse, in the PiHole Doc, they specify that : While these may still work, they are likely to be removed in a future version. Where applicable, alternative variable names are indicated.

So the UnRaid Template just need a little update then ! :)