search

dewango / BottomNavigationBarXF

Bottom Navigation Bar for Xamarin Forms
MIT License
187 stars 97 forks source link

is there a way to hide pink bar just above bottom toolbar in the sample? #13

Open Korayem opened 8 years ago

Korayem commented 8 years ago

I tried all the following but nothing worked:

_bottomBar.NoTabletGoodness();
_bottomBar.UseFixedMode();
_bottomBar.HideShadow();
_bottomBar.NoTopOffset();
_bottomBar.NoNavBarGoodness();
andreinitescu commented 8 years ago

Pink color comes from this line https://github.com/thrive-now/BottomNavigationBarXF/blob/master/example/BottomBarXFExample/App.xaml.cs#L16

bottomBarPage.BarBackgroundColor = Color.Pink;

keytronic commented 8 years ago

It's no a solution. You can change the color of the bar but will be still here. See #6

Korayem commented 8 years ago

@JordanGout thanks for pointing that out

I added a comment on how to fix it and remove pink line https://github.com/thrive-now/BottomNavigationBarXF/issues/6#issuecomment-242866636

escamoteur commented 7 years ago

I added a PR for it https://github.com/thrive-now/BottomNavigationBarXF/pull/16

DominicFrei commented 7 years ago

Hey guys! Does the already merged PR by @escamoteur fully solve this issue for you? @Korayem @andreinitescu @JordanGout

ghost commented 7 years ago

You can fix it by changing "Height" to "MeasuredHeight" in the OnLayout of the renderer.

_pageController.ContainerArea = new Rectangle(0, 0, context.FromPixels(width), context.FromPixels(_frameLayout.MeasuredHeight));