search

dewango / BottomNavigationBarXF

Bottom Navigation Bar for Xamarin Forms
MIT License
187 stars 97 forks source link

Fix white empty page bug discussed in #6 #21

Closed ice-j closed 7 years ago

ice-j commented 7 years ago

Replace magic number 0.909 and height calculation for ContainerArea discussed in issue #6.

I've approximately calculated the 0.909 value of page height to be the correct size of the ContainerArea property for the BottomBarPage, but seems I was wrong. That is working on most of the devices, but I discovered it is still buggy on some non-standard displays like the Galaxy Note 3, which features 5.7" display, and the Xiaomi Redmi Note 3 Pro. Therefore I've played around with getting the real child's height and it seems to be working great with the _frameLayout's Height property.

aklingensmith commented 7 years ago

Hi, which .net profile does this package use? I can't seem to find it - sorry if commenitng here was bad

DominicFrei commented 7 years ago

@aklingensmith If you have a question related to an open issue, ask there. If not, feel free to create a new issue. :)

@ice-j Thanks for your work. Very much appreciated!