dewango / BottomNavigationBarXF

Bottom Navigation Bar for Xamarin Forms
MIT License
187 stars 97 forks source link

Cannot run the library under Android 4.0.3 (API 15) #40

Open geekzolanos opened 7 years ago

geekzolanos commented 7 years ago

Greetings! When i try to integrate the library on a xamarin forms project working under Android 4.0.3, It Hangs on a unrecoverable exception and it closes.

The error message refers to a unknown function called "getMinimumHeight". After some research i found that the error was generated by a call to a unsupported method on the API (getMinimumPage was supported since API 16). The call is currently done on BottomNavigationBarRenderer.cs at line 206:

int tabsHeight = Math.Min (height, Math.Max (_bottomBar.MeasuredHeight, _bottomBar.MinimumHeight));

However i was able bypass the exception making a quick (and dirty) workaround:

int tabsHeight = Math.Min (height, _bottomBar.MeasuredHeight);

With that last change the example project was able to run perfectly under Android 4.0.3.

I think this is an important detail because all libraries associated with this one starts his support with API 13 (Honeycomb) :)