Dominic-Kua commented 1 year ago

Added EA prefix for Gen 2 inverters

dewet22 commented 1 year ago

Thanks @Dominic-Kua and @Smithmg7 , merging now.

codecov[bot] commented 1 year ago

Codecov Report

Merging #22 (7922bdf) into main (51e5d51) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   84.94%   84.94%           
=======================================
  Files          24       24           
  Lines        2032     2032           
  Branches      201      201           
=======================================
  Hits         1726     1726           
  Misses        251      251           
  Partials       55       55

Impacted Files	Coverage Δ
givenergy_modbus/model/inverter.py	`99.06% <ø> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Smithmg7 commented 1 year ago

Thank you for this you're a star, do you still monitor the Givenergy team group, if you do will update there any potential changes including registers and inverter types.

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg

From: Dewet Diener @.> Sent: Saturday, March 4, 2023 10:56:54 PM To: dewet22/givenergy-modbus @.> Cc: Michael Smith @.>; Mention @.> Subject: Re: [dewet22/givenergy-modbus] Update inverter.py (PR #22)

Merged #22https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdewet22%2Fgivenergy-modbus%2Fpull%2F22&data=05%7C01%7C%7C8b74cf2082344d0503f108db1d03c061%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638135674161161634%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=THvK2DT4WAzCwn6gbxSHVC%2FqV3k%2FYCUWiyNoY4I1C%2B8%3D&reserved=0 into main.

— Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdewet22%2Fgivenergy-modbus%2Fpull%2F22%23event-8666961507&data=05%7C01%7C%7C8b74cf2082344d0503f108db1d03c061%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638135674161161634%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=oDClJKgy1pWpMjwff4dFR%2BkLqZ2%2Bz%2FIER%2FoN2XicFJY%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA3UVPGQD3C3JYZYFQEHMLZ3W2PCDNANCNFSM6AAAAAAU75K3AI&data=05%7C01%7C%7C8b74cf2082344d0503f108db1d03c061%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638135674161317899%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=g2%2FkQe6W1qRt36WmGSxMu9UtSUSnYbztMp5VNnNbqp8%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

dewet22 / givenergy-modbus

Update inverter.py #22

Codecov Report