search

dewet22 / givenergy-modbus

A python library to access GivEnergy inverters via Modbus TCP on a local network, with no dependency on the GivEnergy Cloud.
Other
21 stars 14 forks source link

Need a fresh release #26

Open SamKua opened 1 year ago

SamKua commented 1 year ago

This code is in use in another givenergy integration, which is broken for us due to the missing serial number prefix. Apparently the other integration requires a release on this in order to use the fix which my partner submitted (https://github.com/dewet22/givenergy-modbus/commit/01224c77bab68309e06c0dd7e946dfe41b28de22) which has been merged.

Its been over a year since a new version was released. Could one be done? Thanks.

Tau512 commented 1 year ago

we could really do with this @dewet22. This is used in HomeAssistant so every HA update reverts it back to an unfixed version (i assume v0.10.1) thus each update means manually re-applying the EA prefixed inverter. While simple to do, it is a faff updating it multiple times a month with each HA update. Looks like theres also requirement for the latest gen3 too.

the EA gen2 fix has been solid for me for months.

a side point; i updated HA a few days ago and it appears to have dropped the 'cls.' and potentially moved to elsewhere in the code (https://github.com/dewet22/givenergy-modbus/commit/01224c77bab68309e06c0dd7e946dfe41b28de22). not sure whats going on there

britkat1980 commented 1 year ago

we could really do with this @dewet22. This is used in HomeAssistant so every HA update reverts it back to an unfixed version (i assume v0.10.1) thus each update means manually re-applying the EA prefixed inverter. While simple to do, it is a faff updating it multiple times a month with each HA update. Looks like theres also requirement for the latest gen3 too.

the EA gen2 fix has been solid for me for months.

a side point; i updated HA a few days ago and it appears to have dropped the 'cls.' and potentially moved to elsewhere in the code (01224c7). not sure whats going on there

Are you using GivTCP? If so it shouldn't use the default version, I provide a forked version of this library which calculates Inverter stats without using the serial number...

Tau512 commented 1 year ago

Are you using GivTCP? If so it shouldn't use the default version, I provide a forked version of this library which calculates Inverter stats without using the serial number...

I'm using the https://github.com/cdpuk/givenergy-local, which states it uses this version. (cdpuk is waiting for an updated release) I'm open to moving to GivTCP, but was on the impression givenergy-local was the only solution to have local polling and was the current recommended addon to use.

britkat1980 commented 1 year ago

OK, that makes more sense. GivTCP is officially supported by GivEnergy and I work with their Dev team on updates etc... It is an addon, rather than an integration, so is (mildly) more complex to install, but if you run HA via a VM or supervisor then you can run addons. GivTCP is fully local. There's a good user community facebook group if you want to find out more

dewet22 commented 1 year ago

The v0 branch is really unsupported at this point. It isn't a good implementation, and suffers a lot from timing subtleties because of its synchronous implementation. The v1 release is completely async and will play better with multiple clients talking to the inverter. This library has always intended to be a base-line implementation, with clients to be built on top of it. I have a prototype HASS integration working very reliably with it, but it'd be trivial to add on more features (some of which I want) like MQTT and influxdb support.

JRascagneres commented 10 months ago

@dewet22 Can you provide some example code for the v1 branch? With GivEnergyClient not existing anymore