Do not set battery_soc_reserve as part of set_mode_storage

dewet22 / givenergy-modbus

A python library to access GivEnergy inverters via Modbus TCP on a local network, with no dependency on the GivEnergy Cloud.

Other

19 stars 15 forks source link

Do not set battery_soc_reserve as part of set_mode_storage #27

Open reidjr opened 1 year ago

reidjr commented 1 year ago

Feature request:

When used with a Gen2 Inverter : Setting battery_soc_reserve to 100 stops any discharge. Can this be removed from set_mode_storage ? Currently calling set_mode_storage for either Timed Export/Disharge on gen2 effectively disables the battery from discharge.

def set_mode_storage()
........
 ret.extend(set_shallow_charge(100))  # r110=100

I dont think that the portal or app set this value when Timed Discharge or Timed Export is selected. Is it needed for Gen1 firmware ?

britkat1980 commented 1 year ago

Agreed, this should be removed from the command.py.