search

dewet22 / givenergy-modbus

A python library to access GivEnergy inverters via Modbus TCP on a local network, with no dependency on the GivEnergy Cloud.
Other
19 stars 15 forks source link

Update Energy Total Registers #4

Closed britkat1980 closed 2 years ago

britkat1980 commented 2 years ago

Updated some register values, modified tests and have run and passed them in my vscode venv. Hopefully I've done this right...

codecov[bot] commented 2 years ago

Codecov Report

Merging #4 (ac0b6e2) into main (5b1a3e2) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   90.01%   90.01%           
=======================================
  Files          17       17           
  Lines        1653     1653           
  Branches      152      152           
=======================================
  Hits         1488     1488           
  Misses        142      142           
  Partials       23       23
Impacted Files Coverage Δ
givenergy_modbus/model/inverter.py 100.00% <100.00%> (ø)
givenergy_modbus/model/register.py 99.17% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b1a3e2...ac0b6e2. Read the comment docs.

dewet22 commented 2 years ago

Very nice, looks great!