search

dewittpe / cpr

Control Polygon Reduction: Methods for quick and efficient placement of internal knots for B-splines and tensor products of B-splines.
http://www.peteredewitt.com/cpr/
2 stars 0 forks source link

deprecate newknots #31

Closed dewittpe closed 7 years ago

dewittpe commented 7 years ago

In the file R/update_bsplines.R you'll find the comment

newknots are used in the cpr and cnr calls. No other use for this function.
It should, at some point, be deprecated in favor of update_bsplines

dewittpe commented 7 years ago

At this time, this is a don't fix, more than a wontfix. The complex eval(stats::update(.... call that uses the newknots call is best left as is. This is an issue that could be resolved after a bigger redesign of the package.