search

dewski / itunes

A Ruby wrapper around the iTunes API that lets you search for any sort of data that is available on the iTunes store.
http://github.com/dewski/itunes
MIT License
122 stars 29 forks source link

Few improvements #9

Closed sosedoff closed 12 years ago

sosedoff commented 12 years ago

I made a few improvements to the library,

  1. Added request options for handling timeouts. Sometimes the request is being processed for a very long time (~ 30+ sec). Its a const now, but we could possibly make it a configurable option.
  2. Added JSON to runtime requirements. If you dont have any json library installed the whole test suite goes down.
stve commented 12 years ago

The request options change looks good to me. I think it might be better to make json a development_dependency as we don't need to mandate a parser lib other than for development.

sosedoff commented 12 years ago

True that, i'll commit right now.

dewski commented 12 years ago

In the future if we add any configuration we can move REQUEST_OPTIONS, but for now that'll do. Nice job!