search

dewski / json_builder

Rails provides an excellent XML Builder by default to build RSS and ATOM feeds, but nothing to help you build complex and custom JSON data structures. JSON Builder is here to help.
http://garrettbjerkhoel.com/json_builder/
MIT License
244 stars 52 forks source link

warning: method redefined #51

Open lloeki opened 7 years ago

lloeki commented 7 years ago

When running tests on a project depending on json_builder some warnings are raised:

This is because with a recent rake (>=11.0), ruby warnings are now on by default.

/Users/lloeki/.gem/ruby/2.3.4/gems/json_builder-3.1.7/lib/json_builder/compiler.rb:70: warning: method redefined; discarding old array
/Users/lloeki/.gem/ruby/2.3.4/gems/json_builder-3.1.7/lib/json_builder/compiler.rb:147: warning: method redefined; discarding old pretty_print

What do you think about fixing this warning as well as running the spec suite with ruby -w / $VERBOSE = true / t.warning = true (or bumping rake) ?