dex4er / nss-docker

NSS module for finding Docker containers
GNU Lesser General Public License v2.1
42 stars 14 forks source link

Allow optional plain hostnames (no FQDN) #11

Closed nathanjrobertson closed 4 years ago

nathanjrobertson commented 4 years ago

I have a use case where I really need plain host names, with no ".docker" suffix. We have a container running an SSO IDP, another container with a web server as an SSO SP, and a third container running webdriver tests. The issue is that SAML2 is quite fussy about host names, and each host needs a known host name. When developing on the host machine, testing in the host machines web browser and testing using webdriver on the host, you currently need the ".docker" extension. However, when testing within the webdriver container (as is the case when running GitHub Actions automated on-checkin testing) requires no ".docker" extension. Life would be so much easier if the host could know the container names without the suffix.

I see another user has created a pull request to allow DOCKER_DOMAIN_SUFFIX to be an empty string at compile time. That could work, but seems a bit of a hack, plus will never be the default configuration on a distro installed package. This configuration more mirrors what users expect DNS resolution to look like. When initially installing the package (and not reading the documentation), I expected to be able to use plain hostnames, and had to google to find out about the ".docker" suffix. I believe this patch fixes that usability issue.