search

dexX7 / java-libbitcoinconsensus

JNA binding and Java wrapper for libbitcoinconsensus
Other
9 stars 3 forks source link

Add to Bitcoin Core's list of example implementations #9

Closed msgilligan closed 9 years ago

msgilligan commented 9 years ago

java-libbitcoinconsensus should be listed on doc/shared-libraries.md in Bitcoin Core.

dexX7 commented 9 years ago

Sure, but do you think it's ready?

msgilligan commented 9 years ago

It's ready to be an example implementation. ;) It's ready for people to start using/testing, isn't it? We can put any disclaimers we want on the project page (about being alpha, pre-alpha, etc.), but I would think we should make the project easy to find for those looking for a Java implementation. That way they can use it, report bugs and submit patches as necessary, rather than start a parallel implementation.

We should also announce it on the bitcoinj mailing list. I can send the message if you don't want to do it yourself.

msgilligan commented 9 years ago

Congrats, @dexX7 !

msgilligan commented 9 years ago

Do you want to announce it on the bitcoinj mailing list, or should I?

dexX7 commented 9 years ago

Thanks, @msgilligan! Please go ahead with the mailing list post, if I'd like to. :)

msgilligan commented 9 years ago

if I'd like to.

@dexX7 I'm not sure what you mean by the above.

dexX7 commented 9 years ago

Ahh, sorry, ... I meant "you" of course! :)

It would be great, if you could post on the BitcoinJ mailing list, but only if you want to. :)

msgilligan commented 9 years ago

I want to. I had asked about it earlier, so I feel obligated to let people know. I'd also like to see some users and contributors :)

dexX7 commented 9 years ago

Nice! Over the weekend I'm probably going to take a closer look at setting up Bintray.

msgilligan commented 9 years ago

You can definitely look at the Gradle scripts in OmniJ or bitcoinj-addons. Feel free to ask any questions or, if you'd like, I could even put together a PR.

dexX7 commented 9 years ago

Thanks, help would be very appreciated! I was thinking about publishing to Bintray every release tag, and ideally the Groovy/JavaDoc would be published (e.g. to AWS S3), too. It looks like could be automated via Travis (see https://github.com/dexX7/java-libbitcoinconsensus/issues/12#issuecomment-142991966), but I haven't tested it yet. I'd later try to tackle it by creating a dummy/test repo and see how/if it works, but doing it manually would already be a step forward. :)

msgilligan commented 9 years ago

I'll set up the Gradle scripts for (manual) Bintray publishing this weekend.

Autopublishing to Bintray on a release tag is a great idea. I'd like to learn how to do it from Travis and/or Jenkins.

I would recommend publishing to Github pages over AWS S3 because it's free.

msgilligan commented 9 years ago

I sent a low-key announcement to the bitcoinj mailing list just now: https://groups.google.com/d/topic/bitcoinj/oZgCyo7UX2g/discussion

dexX7 commented 9 years ago

Thanks @msgilligan, very appreciated!