Closed transitive-bullshit closed 1 month ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
dexter | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 7, 2024 7:54am |
Note: the pnpm lockfile was also updated to the latest v9.
@rileytomasek maybe we don't even need all of the Telemetry
generics, and we just KISS? I was just trying to follow the existing pattern.
@transitive-bullshit I tested locally against Dexa source and there were no issues 👌🏻.
I can't think of a scenario where we need the generics for Telemetry
and it makes a pretty big mess of the code. It was easier to start from scratch so I just opened #47 with the simplified version.
Desc
Extends https://github.com/dexaai/dexter/pull/38 to no longer depend on
@sentry/node
, but rather a flexible, base, sentry-like telemetry provider.By default, models will use a
DefaultTelemetry
if not given a telemetry provider like@sentry/node
.I added a unit test to ensure that at least the types of
@sentry/node
match the expectedTelemetry.Base
provider type.@rileytomasek I'm sure there may be a cleaner way to do this, but I felt like the telemetry provider belonged outside of
model
since it could theoretically be used fordatastore
in the future. At the very least, this change lets us continue iterating on Dexter without it being dependent on Sentry, which I think is a net win.Example