Recently brew updated fmt version from 10.1 to 11.0. In order to prevent build errors from happening after we upgrade Folly, the following changes are made:
Error "'this' argument to member function 'format' has type 'const fmt::formatter', but function is not marked const".
The new fmt v11 forces the const check. To fix this error, the "const" keyword was added to the format() function declarations.
Error "error: static assertion failed due to requirement 'formattable_char': Mixing character types is disallowed." The new fmt v11 added a check if the arguments of fmt::make_format_args() have mixing different character types (e.g., char vs wchar_t or std::string vs folly::Range<const char*>). To fix this, we need to convert the folly::StringPiece to string.
These changes will be needed after we upgrade Folly, which is also dependent on fmt v11. The changes are backward compatible for fmt v10.
Recently brew updated fmt version from 10.1 to 11.0. In order to prevent build errors from happening after we upgrade Folly, the following changes are made:
Error "'this' argument to member function 'format' has type 'const fmt::formatter', but function is not marked const".
The new fmt v11 forces the const check. To fix this error, the "const" keyword was added to the
format()function declarations.Error "error: static assertion failed due to requirement 'formattable_char': Mixing character types is disallowed." The new fmt v11 added a check if the arguments of fmt::make_format_args() have mixing different character types (e.g., char vs wchar_t or std::string vs folly::Range<const char*>). To fix this, we need to convert the folly::StringPiece to string.
These changes will be needed after we upgrade Folly, which is also dependent on fmt v11. The changes are backward compatible for fmt v10.
Fixes https://github.com/facebookincubator/velox/issues/10886
Ursprünglich gepostet von @yingsu00 in https://github.com/facebookincubator/velox/pull/10904