search

dexidp / dex

OpenID Connect (OIDC) identity and OAuth 2.0 provider with pluggable connectors
https://dexidp.io
Apache License 2.0
9.19k stars 1.67k forks source link

Switch to semantic import versioning #2088

Open nabokihms opened 3 years ago

nabokihms commented 3 years ago

Is your feature request related to a problem?

Semantic import versioning is the set of rules on how to do package versioning.

Describe the solution you'd like to see

We need to consider switching to semantic importing versioning for the v3 major version of Dex.

  1. The benefits we would earn from switching are fixes for various go environment tools, e.g., go get, goproxy, pkg.go.dev website integration. Thus this is not urgent.
  2. This is a breaking change, and we can't do it right now. See https://github.com/dexidp/dex/pull/2087 for more details.

Describe alternatives you've considered

Unfortunately, all go environment tools work with these recommendations. The only alternative right now is to keep the normal package name and abstain from integration with the tools I mentioned above.

Additional context

It looks like semantic import versioning rules were designed for libraries. There are no benefits they bring to the application project.

drauschenbach commented 2 years ago

I am also seeing this issue. My renovate CI automation keeps trying to get me to "upgrade" to Dex 0.6.1 (Sep 2016?). And I have to import the Dex package using a Git hash instead of a tag, which is a bookkeeping burden to know what version I am on.

ptman commented 1 month ago

Why exactly does https://pkg.go.dev/github.com/dexidp/dex/server break at 2.13.0 and not at 1.whatever preceding 2.0?

nabokihms commented 1 month ago

@ptman this is because go modules were introduced around this time.