dexidp / helm-charts

Dex Helm chart repository
Apache License 2.0
51 stars 82 forks source link

Use HTTPS port in Ingress when enabled #102

Open zach-mitchell-rtx opened 1 year ago

zach-mitchell-rtx commented 1 year ago

Overview

When enabling HTTPS, the ingress still forwards traffic to the service over HTTP. This PR sets the destination port to the HTTPS port when .Values.ingress.https is true.

What this PR does / why we need it

Enabling HTTPS currently does nothing for the communication between the ingress and the service, defeating the purpose altogether. With this PR HTTPS is also used between the service and ingress (when complemented with the necessary annotation for nginx).

Special notes for your reviewer

Checklist

Signed-off-by: Zach Mitchell zachlmitchell@gmail.com