bug: Inconsistent image tagging in Helm chart appVersion

dexidp / helm-charts

Dex Helm chart repository

Apache License 2.0

50 stars 82 forks source link

bug: Inconsistent image tagging in Helm chart appVersion #125

Open mihaigalos opened 6 months ago

mihaigalos commented 6 months ago

Preflight Checklist

[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I have searched the issue tracker for an issue that matches the one I want to file, without success.
[X] I am not looking for support or already pursued the available support channels without success.

Chart

dex

Version

v2.37.0

Expected Behavior

Consistent tagging between appVersion and image tag between Chart.yaml and values.yaml.

Actual Behavior

Currently, releases contain Helm charts which have Chart.yaml appVersion: "X.YY.Z". But the values.yaml tag references a different format (vX.YY.Z), also instructing users that if you don't specify anything, the appVersion is used.

We are automatically updating upstream charts with PRs which are automatically opened in our internal repos, this behavior impedes us.

Please help. Thank you.

Steps To Reproduce

No response

Additional Information

No response

Values

No response

sagikazarmark commented 6 months ago

Although this is taken care of in the deployment template here, I agree it would be easier to use the same tag as version.

I'm not entirely sure I understand how it impedes you, though.

mihaigalos commented 6 months ago

We have an automatic update mechanism that looks at this repo's releases, matches the release with gh-pages branch :: index.yaml :: appVersion. It then takes that appVersion and considers it as a tag (same way it's described) and that is then used as the image to be used with the release.

Other projects to it the same way - examples:

Don't get me wrong, it ca be vX.Y.Z or X.Y.Z, but at least consistent between the Chart.yaml and index.yaml

sagikazarmark commented 6 months ago

Don't get me wrong, it ca be vX.Y.Z or X.Y.Z, but at least consistent between the Chart.yaml and index.yaml

You mean git tag and appVersion, don't you?

mihaigalos commented 6 months ago

So probably also that would have to be unified as well.. 😅

But we are not consuming that, attribute. I'm refering to Chart.yaml and index.yaml.

sagikazarmark commented 6 months ago

I don't see how Chart.yaml and index.yaml can differ. index.yaml is created based on Chart.yaml.

When no tag is specified in values, the prefix is automatically prepended to the value of appVersion.

What we can do, is remove that automatic prefixing and use the full tag in appVersion instead.

Can't really change anything else. Not sure if this would solve your problem though.

mihaigalos commented 6 months ago

What we can do, is remove that automatic prefixing and use the full tag in appVersion instead.

That would definitely help! 😄

mihaigalos commented 4 months ago

Hi @sagikazarmark, do you need any help with this? I can provide a PR if you think it's worthwhile.

sagikazarmark commented 4 months ago

@nabokihms what do you think?

I'm not against the above outlined solution.

nabokihms commented 4 months ago

I'm ok with this change if we speak about removing the automatic v prefix.

mihaigalos commented 1 month ago

Hi. Any news here?