Add ability to set annotations on the Deployment

dexidp / helm-charts

Dex Helm chart repository

Apache License 2.0

50 stars 82 forks source link

Closed Krast76 closed 1 year ago

Krast76 commented 1 year ago

This PR add ability to set annotations on the deployment.

Sometimes you need to add annotations on your Deployment.

For example I need it to automatically restart Dex when the TLS secret got updated.

[ ] Change log updated in Chart.yaml (see the contributing guide for details)
[ ] Chart version bumped in Chart.yaml (see the contributing guide for details)
[ ] Documentation regenerated by running make docs

sebastiangaiser commented 1 year ago

Any updates on this? This looks like also implemented in https://github.com/dexidp/helm-charts/pull/105 but I like this wording more...

Krast76 commented 1 year ago

Any updates on this? This looks like also implemented in #105 but I like this wording more...

I have rebased it.

Krast76 commented 1 year ago

If i can do something else tell me @sebastiangaiser :)

sebastiangaiser commented 1 year ago

At least I'm no developer of this project 😅 But I would like to see this PR merged.

sagikazarmark commented 1 year ago

Thank you @Krast76 ! I'm going to accept #105

Krast76 commented 1 year ago

At least I'm no developer of this project 😅 But I would like to see this PR merged.

That's why you asked for updates on it 😅

Thank you @Krast76 ! I'm going to accept https://github.com/dexidp/helm-charts/pull/105

I close this one then.