dexidp / website

Dex website
https://dexidp.io
Apache License 2.0
12 stars 64 forks source link

Spacing around markdown links #60

Open nate-double-u opened 3 years ago

nate-double-u commented 3 years ago

It looks like there is space being added around links, causing some punctuation to be incorrectly spaced.

Using the Getting Started page to illustrate:

This code: Screen Shot 2020-10-22 at 10 59 43 AM

Generates this output:

Screen Shot 2020-10-22 at 10 59 56 AM

Moving the quotation marks outside the link Screen Shot 2020-10-22 at 11 01 10 AM

Generates this output:

Screen Shot 2020-10-22 at 11 01 55 AM

I thought that maybe the link style was an issue, so I updated that too: Screen Shot 2020-10-22 at 11 03 23 AM

But that generates the same output

Screen Shot 2020-10-22 at 11 03 53 AM

Lastly I thought maybe it was the italic: Screen Shot 2020-10-22 at 11 04 45 AM

But removing it generates the same spacing issues as before.

Screen Shot 2020-10-22 at 11 05 26 AM

Probably this has to do with the styling somewhere, and I expect this issue is the underlying cause of these ~bugs~ issues:

nate-double-u commented 3 years ago

There is a solution to this issue here: https://github.com/cncf/hugo-netlify-starter/pull/93

chalin commented 3 years ago

FYI, you'll probably want to wait for https://github.com/cncf/hugo-netlify-starter/issues/77 to be fixed before adopting the render-link hook used in the starter.

chalin commented 3 years ago

FYI, you'll probably want to wait for cncf/hugo-netlify-starter#77 to be fixed before adopting the render-link hook used in the starter.

The fix has landed.

nabokihms commented 4 months ago

We migrated to Docsy. There is probably no issue anymore. At least all previously found bugs are now fixed.