Tip page (#78) - Githubissues

dexlab-io / dexpay-pos

Dexpay: POS, a modularized and extensible point of sale which enables Merchants to accept payments in ETH, DAI and xDAI.

https://www.dexlab.io/

MIT License

27 stars 20 forks source link

Tip page (#78) #86

Open e18r opened 5 years ago

e18r commented 5 years ago

In order to integrate the tip page into the overall design of the dapp, I decided to create a modal window in which to put the payment details. I also decided to add a new tab (but only in desktop mode) called "Tip" that opens this modal. However, it is also possible to access this tipping modal by visiting the URL /address/:id/tip. This is, in fact, the only possible way to access the tipping page in mobile mode.

Please let me know your oppinions about my work so far.

e18r commented 5 years ago

I changed the modal to a regular page in order to accomodate for the recent tips. I implemented all the watching fuhctionality, and modified the RecentPayments component in order to integrate it into the page. It's still lacking some visual adjustments, as well as a live update of the recent payments that reflects new payments. Also filtering only tips is missing, and as well as the animation after a tip is received.

e18r commented 5 years ago

I will keep working on this on Monday.

e18r commented 5 years ago

Almost ready. The desktop version is already working as expected; only a few cosmetic improvements required. The mobile version is still missing.

Alexintosh commented 5 years ago

@e18r great step forward man! Looks a lot like I imagined it. A few things I notice are:

The page disappear when reducing the page with in mobile with
The confetti go under the navbar
The address doesn't change when clicking on the navbar for the tip page

e18r commented 5 years ago

@Alexintosh I finished!

e18r commented 5 years ago

@dimarconicola @Alexintosh Here are the requested changes.