search

dexpota / kitty-themes

A collection of themes for kitty terminal 😻
MIT License
2.56k stars 196 forks source link

Kitty creates broken theme.conf #14

Closed TeslaNguyen closed 5 years ago

TeslaNguyen commented 5 years ago

Hi!

ln -s ./kitty-themes/themes/Floraverse.conf ~/.config/kitty/theme.conf or in my case ln -s ./kitty-themes/themes/Solarized_Dark_-_Patched.conf ~/.config/kitty/theme.conf creates a broken theme.conf

What can I do?

Cheers

Luflosi commented 5 years ago

A bit more information would be nice. You could have mentioned that ln -s ./kitty-themes/themes/Floraverse.conf ~/.config/kitty/theme.conf is from the README.md file. Did you follow the three installation steps in https://github.com/dexpota/kitty-themes#source-code exactly? What exactly is "broken" about theme.conf? Following the three steps works for me.

TeslaNguyen commented 5 years ago

I followed these exact steps, yes, only that I have substituted Floraverse for Solarized_Dark_-_Patched (the theme I'd actually like to install).

I can't tell you what is broken about theme.conf exactly, but here's what it looks like.

Screenshot from 2019-08-12 23-11-38 Screenshot from 2019-08-12 23-11-54

Luflosi commented 5 years ago

If the link is broken, it means, that the file it points to, doesn't exist. Are you sure, that the kitty-themes directory is in ~/.config/kitty? The full path should be: ~/.config/kitty/kitty-themes. Also please double-check, that theme.conf is also in ~/.config/kitty.

TeslaNguyen commented 5 years ago

I've added two screenshots for you to verify the locations.

Screenshot from 2019-08-12 23-20-48 Screenshot from 2019-08-12 23-20-05

TeslaNguyen commented 5 years ago

I just noticed that theme.conf is referring to /kitty-themes/themes, how did I miss that? What exactly should I change so that kitty knows what's what?

Luflosi commented 5 years ago

You probably meant ./kitty-themes/themes, right? The . is important. Starting the path with a / means that it is an absolute path, which is different from a relative path. Alternatively you can also leave out the ./, which should work just as well when symlinking. Either create a themes directory inside kitty-themes or use ln -s ./kitty-themes/Solarized_Dark_-_Patched.conf ~/.config/kitty/theme.conf (without the themes). You could also not use a symlink at all and specify the path to the config file directly in kitty.conf. The symlink is just for convenience.

TeslaNguyen commented 5 years ago

I did just that, create themes in kitty-themes and moved Solarized_Dark_-_Patched.conf there; theme.conf is now a working file, however the theme per se is still not being applied in the kitty terminal.

Does include ./theme.conf have to go somewhere else?

Screenshot from 2019-08-12 23-38-18

Luflosi commented 5 years ago

Remove the # and space in front. That tells kitty, that everything after that is just a comment and should be ignored. You also have to restart kitty for the changes to take effect.

Luflosi commented 5 years ago

I recommend to put that line at the very bottom, so that there are no settings that might override the settings in the theme.

TeslaNguyen commented 5 years ago

Remove the # and space in front. That tells kitty, that everything after that is just a comment and should be ignored. You also have to restart kitty for the changes to take effect.

That worked! I've only added the # because I was quite sure it said that it had to be there, my mistake.

It's working now, thank you very much!

Luflosi commented 5 years ago

You're welcome. I see now, this is an issue in the documentation. When following the instructions under or download just one theme:, the symlink in step two is broken, as described in this issue. I followed the alternative instructions above, which work correctly. I'll make a pull request to add the themes directory to the download path. You can keep this issue open until it's merged.

TeslaNguyen commented 5 years ago

Sounds good. Thank you again and have a great evening, I really appreciate you taking the time to help me out with this!