dexpota / kitty-themes

A collection of themes for kitty terminal 😻
MIT License
2.53k stars 195 forks source link

Solarized Light in Vim sets background to dark in Kitty #44

Open FernandoBasso opened 3 years ago

FernandoBasso commented 3 years ago

The themes/Solarized_Light.conf theme is producing a dark background in Vim with 'altercation/vim-colors-solarized'.

From inside vim, :echo &background reports “light”, and :echo $TERM reports “xterm-kitty”.

That said, I tried using this Solarized Light from a kitty issue) and it works fine.

I could also add that this vim solarized light theme I use works fine with all VTE terminals I have tried (xfce4-terminal, mate-terminal, terminator, all using the solarized palette) and also using those terminals + tmux.

EDIT: I took sometime to debug the problem, and it looks like color7 and color15 are the ones causing Vim Solarized Light to have a dark background.

Proposed Fix

I suggest replacing the current (which causes the darkish stuff mentioned above):

color7 #262626
color15 #1c1c1c

With these (from the issue I linked above, which really makes a lightish backround theme for Vim Solarized Light and do not seem to cause any color strangeness or unintended consequence for the terminal itself not running an editor):

color7  #eee8d5
color15  #fdf6e3
vikahl commented 3 years ago

Just wanted to say thank you for the fix as I had the same problem but did not manage to solve it myself.

krzkrzkrz commented 3 years ago

Yeap, this fix works for me too

The themes/Solarized_Light.conf theme is producing a dark background in Vim with 'altercation/vim-colors-solarized'.

From inside vim, :echo &background reports “light”, and :echo $TERM reports “xterm-kitty”.

That said, I tried using this Solarized Light from a kitty issue) and it works fine.

I could also add that this vim solarized light theme I use works fine with all VTE terminals I have tried (xfce4-terminal, mate-terminal, terminator, all using the solarized palette) and also using those terminals + tmux.

EDIT: I took sometime to debug the problem, and it looks like color7 and color15 are the ones causing Vim Solarized Light to have a dark background.

Proposed Fix

I suggest replacing the current (which causes the darkish stuff mentioned above):

color7 #262626
color15 #1c1c1c

With these (from the issue I linked above, which really makes a lightish backround theme for Vim Solarized Light and do not seem to cause any color strangeness or unintended consequence for the terminal itself not running an editor):

color7  #eee8d5
color15  #fdf6e3