diff kitten is not supported

[scopatz]

These themes do not match colors with the stock diff kitten. This can be quite jarring if you are on a dark theme. I am happy to help out here, if this is of interest.

[dexpota]

I can see the frustration of using diff kitten without matching colours and I am interested in creating these configuration files.

I think there are two possible solutions, the first one is to try to generate these configuration files starting from the themes' configurations. The second one is to write for each theme the configuration files manually (or semi-manually).

I tried to make a configuration file for the theme I am using right now and the results are not very nice (especially the pygments' scheme). A simple copy of the background and foreground colours is not sufficient.

(English is not my first language if something is not clear just tell me.)

[scopatz]

I am interested in creating these configuration files.

Excellent! Should these be separate configuration files, or should the diff entries be added to the existing theme configuration files? I think it would be nicest to add them to the existing files.

I tried to make a configuration file for the theme I am using right now and the results are not very nice (especially the pygments' scheme).

Yeah I understand this issue. I use the xonsh shell, which already let's you set a theme for shell itself based on pygments style. So my diff alias is actually,

kitty +kitten diff --override pygments_style=$XONSH_COLOR_STYLE

the first one is to try to generate these configuration files starting from the themes' configurations

This is what I was going to start with. Choosing a default pygments style to use (if you aren't using xonsh) might need to be more manual.

[scopatz]

Oh I guess it needs to be a separate file because the diff tool itself messes up if you pass a regular config file in:

$ d --config ~/miniconda/share/kitty-themes/SeaShells.conf geometry.xml materials.xml 
[179 18:37:35.996737] Ignoring unknown config key: cursor
[179 18:37:35.996779] Ignoring unknown config key: selection_background
[179 18:37:35.996800] Ignoring unknown config key: color0
[179 18:37:35.996818] Ignoring unknown config key: color8
[179 18:37:35.996842] Ignoring unknown config key: color1
[179 18:37:35.996873] Ignoring unknown config key: color9
[179 18:37:35.996896] Ignoring unknown config key: color2
[179 18:37:35.996915] Ignoring unknown config key: color10
[179 18:37:35.996934] Ignoring unknown config key: color3
[179 18:37:35.996959] Ignoring unknown config key: color11
[179 18:37:35.996987] Ignoring unknown config key: color4
[179 18:37:35.997011] Ignoring unknown config key: color12
[179 18:37:35.997036] Ignoring unknown config key: color5
[179 18:37:35.997060] Ignoring unknown config key: color13
[179 18:37:35.997085] Ignoring unknown config key: color6
[179 18:37:35.997110] Ignoring unknown config key: color14
[179 18:37:35.997138] Ignoring unknown config key: color7
[179 18:37:35.997165] Ignoring unknown config key: color15

[dexpota]

Yes, it does have to be a separate file. Maybe we can create a file for each theme with a different extension, for example, SeaShells.conf and SeaShells.diff.conf. The user then could install a theme with a simple symlink, ln -s ./kitty-themes/themes/SeaShells.diff.conf ~/.config/kitty/diff.conf

An alternative could be to write these configurations in a separate directory. Either way is fine with me.

[scopatz]

Alright thanks! Also would you mind if the generation script was in Python rather than Bash? It would be a lot easier to do some of the color arithmetic.

[dexpota]

Yes, of course, you can write it in python.

[dexpota]

I assigned this issue to you. I don't think it's a problem, if so please tell me.

[BlueDrink9]

May be of note (and may fix this issue)

[scopatz]

Ahh yeah, that may fix this!

[dexpota]

Closing for inactivity.