nus-pe-script
commented
5 months ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Editing the storage data manually causes the app to crash on load
"A" was put at the end of the salary entry instead of "I"
This caused the program to crash on startup.
[original: nus-cs2113-AY2324S2/pe-interim#391] [original labels: type.FunctionalityBug severity.High]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Although I think that there should be proper exception handling for incorrect file inputs, I believe this bug is a case of extreme user input. The user should not be changing anything in the file directly. If the user wishes to use the same file, it has been recommended in the user guide to copy the full file instead of just the text. Hence, in no situation should the contents be manually changed by the user. Furthermore, the save function of the app would not produce such cases. Therefore, I will reject this bug.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [x] I disagree
Reason for disagreement: The error occured at different locations (one is inside the word income and one is after the '|'). Given the nature of storage, a lot of exception handling cases are required to fix this issue, and for these two separate issues, two fixes are required (one to verify income, one to verify the I). Duplicating this issue therefore is rejected given that different fixes are required to address the issues to ultimately make the storage more robust.
## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** There is a reason why the Professor told us to leave it as a text file, and that is because he wanted us to check if modifying the storage directly does not make the app lose function or become buggy. Additionally, this should not be considered a "case of extreme user input" since it is only a mere whitespace that has been attached to the middle of "income". With this, it should not be discounted that users might make such mistakes (entering the text file and adding a space is definitely a possibility). Additionally, there has been no mention that the save file is not to be modified, nor fixes should a problem occurs apart from contacting the team, which leaves me to reject this issue based on the relative ease (with just a single whitespace) of losing ALL functionality of the app, making it severe. 
Steps to reproduce: login to app enter "add-inflow n/Salary a/5000 d/21/02/2024 t/1700 c/income" enter "quit" Add space in "income" as shown
Relogin to the app.
For the app, I do hope that proper storage management can be better introduced in order to avoid such mishaps in the future. This is critical as the user might not understand why the app is unexpectedly logging out, and the only resolution offered by the team is to report the bug to the support team, without other recourse to continue using the app.