dextboy / pe

0 stars 0 forks source link

Exception error occurs #12

Open dextboy opened 2 months ago

dextboy commented 2 months ago

Steps to reproduce: Enter data into app enter quit add '0' to time (check line 2 below)

Screenshot 2024-04-19 at 5.12.48 PM.png

Screenshot 2024-04-19 at 5.12.32 PM.png

Do consider fixing this, graceful exception handling should occur whenever there is an issue with storage such as wiping the file.

soc-pe-bot commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Editing the storage data manually causes the app to crash on load

"A" was put at the end of the salary entry instead of "I"

image.png

image.png

This caused the program to crash on startup.

image.png


[original: nus-cs2113-AY2324S2/pe-interim#391] [original labels: type.FunctionalityBug severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Although I think that there should be proper exception handling for incorrect file inputs, I believe this bug is a case of extreme user input. The user should not be changing anything in the file directly. If the user wishes to use the same file, it has been recommended in the user guide to copy the full file instead of just the text. Hence, in no situation should the contents be manually changed by the user. Furthermore, the save function of the app would not produce such cases. Therefore, I will reject this bug.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: While both leads the program to crash on load, my issue contains the exception thrown that is not caught by the app, which is of greater severity.


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** There is a reason why the Professor told us to leave it as a text file, and that is because he wanted us to check if modifying the storage directly does not make the app lose function or become buggy. Additionally, this should not be considered a "case of extreme user input" since it is only a mere "0" that has been attached to the start of the time. With this, it should not be discounted that users might make such mistakes (entering the text file and adding a "0" is definitely a possibility). Additionally, there has been no mention that the save file is not to be modified, nor fixes should a problem occurs apart from contacting the team, which leaves me to reject this issue based on the relative ease (with just a single "0") of losing ALL functionality of the app, and also throwing exceptions that are not caught, making it extremely severe. ![Screenshot 2024-04-24 at 10.23.10 AM.png](https://raw.githubusercontent.com/dextboy/pe/main/files/8eb6e901-f4ca-4822-948d-068b132edb2c.png)