search

dextboy / pe

0 stars 0 forks source link

"File saved..." text occurs when help command is typed. #2

Open dextboy opened 2 months ago

dextboy commented 2 months ago

Steps to reproduce: As described in text

Screenshot 2024-04-19 at 4.15.18 PM.png

Unexpected text occuring leads to user misunderstanding the intended feature.

soc-pe-bot commented 2 months ago

Team's Response

file is actually being saved

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

File is saved when inputs not needing saving are used

Good that error handling is done for invalid commands, however not sure why the file needs to be saved and the user notified after every invalid command since an invalid command should not do anything that needs to be saved. Other commands like help and view-history also prompt the save message although there is no new data to be saved which may clutter the user experience.

For invalid command:

image.png

For help command:

image.png

[original: nus-cs2113-AY2324S2/pe-interim#383] [original labels: type.FunctionalityBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

file is actually being saved at every command to ensure accuracy

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** While it is pertinent that the file is actually being saved to ensure accuracy, I vehemently disagree on the notion that the file is to be saved on EVERY command including the help command. The help command is to show users what commands they are able to enter in to the application, thus it does not record nor modify any information related to the app. Thus, the fact that the file is still saved (or shown to users that it is being saved) at the help command only serves to confuse users, and should not be considered a feature.
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** The file is still saved (or shown to users that it is being saved) at the help command only serves to confuse users, and should not be considered a feature. Users will be confused as to whether they typed the wrong command since the help command only shows what commands the user is able to make and does not modify the information in the app in any shape or form. Thus I believe this warrants a "medium" rather than a "very low" due to the nature of the bug, which goes beyond a mere cosmetic bug at this juncture.